mihaibudiu commented on code in PR #5259:
URL: https://github.com/apache/calcite/pull/5259#discussion_r4009031705
##########
core/src/main/java/org/apache/calcite/util/RelToSqlConverterUtil.java:
##########
@@ -339,6 +341,26 @@ public static void unparseBoolLiteralToCondition(SqlWriter
writer, boolean value
writer.endList(frame);
}
+ /**
+ * Writes a two-operand call with an operator other than its own,
+ * parenthesized as that operator requires.
+ *
+ * <p>{@link SqlCall#unparse} chooses the parentheses from the call's own
+ * operator before the dialect is consulted, so an operator that binds less
+ * tightly needs them added here.
+ */
+ public static void unparseWithOperator(SqlWriter writer, SqlOperator
operator,
Review Comment:
Don't you find that this would describe better what the function does?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
