mihaibudiu commented on code in PR #5259:
URL: https://github.com/apache/calcite/pull/5259#discussion_r4009834109
##########
core/src/main/java/org/apache/calcite/util/RelToSqlConverterUtil.java:
##########
@@ -339,6 +341,26 @@ public static void unparseBoolLiteralToCondition(SqlWriter
writer, boolean value
writer.endList(frame);
}
+ /**
+ * Writes a two-operand call with an operator other than its own,
+ * parenthesized as that operator requires.
+ *
+ * <p>{@link SqlCall#unparse} chooses the parentheses from the call's own
Review Comment:
I wonder what happens if not all SQL dialects have the same operation
precedence...
##########
core/src/main/java/org/apache/calcite/util/RelToSqlConverterUtil.java:
##########
@@ -339,6 +341,26 @@ public static void unparseBoolLiteralToCondition(SqlWriter
writer, boolean value
writer.endList(frame);
}
+ /**
+ * Writes a two-operand call with an operator other than its own,
+ * parenthesized as that operator requires.
+ *
+ * <p>{@link SqlCall#unparse} chooses the parentheses from the call's own
Review Comment:
I would shorten this comment to say that this will use parentheses when
necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
