michaelbraun commented on code in PR #5272:
URL: https://github.com/apache/calcite/pull/5272#discussion_r4042984195
##########
core/src/main/java/org/apache/calcite/plan/hep/HepPlanner.java:
##########
@@ -478,6 +478,10 @@ private int depthFirstApply(HepProgram.State programState,
boolean forceConversions, int nMatches) {
while (iter.hasNext()) {
HepRelVertex vertex = iter.next();
+ // Once per vertex: a match ends the loop below, so membership cannot
change in it.
Review Comment:
Would also appreciate help phrasing this better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
