mihaibudiu commented on code in PR #5272:
URL: https://github.com/apache/calcite/pull/5272#discussion_r4067486888
##########
core/src/main/java/org/apache/calcite/plan/hep/HepPlanner.java:
##########
@@ -749,9 +762,19 @@ private static boolean matchOperands(
RelNode rel,
List<RelNode> bindings,
Map<RelNode, List<RelNode>> nodeChildren) {
- if (!operand.matches(rel)) {
- return false;
- }
+ return operand.matches(rel)
+ && matchOperandsWithOperandMatched(operand, rel, bindings,
nodeChildren);
+ }
+
+ /**
+ * Matches the children of {@code rel} against those of {@code operand}, for
a {@code rel}
Review Comment:
Maybe you can start by generating a better javadoc, and this will tell you
what the function name should be. What does "matches" mean here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
