PeterChen123 opened a new pull request, #5287: URL: https://github.com/apache/calcite/pull/5287
## Jira Link [CALCITE-7763](https://issues.apache.org/jira/browse/CALCITE-7763) ## Changes Proposed In `SqlOrderBy`: remove the `final` from the four public fields, then add a `setOperand` override that writes to the correct field by index, matching the order declared in `getOperandList()`: `[query(0), orderList(1), offset(2), fetch(3)]`. The pattern is identical to `SqlWith.setOperand`. ### Why not make `performUnconditionalRewrites` purely functional instead? This was thought about but according to the current patterns and structures, it would be hard and need some refactoring. The validator reads `sourceSelect` back through the original node reference. We cannot eliminate that mutation without touching all downstream code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
