mihaibudiu commented on code in PR #5287:
URL: https://github.com/apache/calcite/pull/5287#discussion_r4090321793
##########
core/src/test/java/org/apache/calcite/test/SqlValidatorTest.java:
##########
@@ -10397,6 +10397,56 @@ void testGroupExpressionEquivalenceParams() {
.fails("Object 'NONEXISTENT' not found");
}
+ /** Test case for
+ * <a
href="https://issues.apache.org/jira/browse/CALCITE-7763";>[CALCITE-7763]
+ * "TABLE t ORDER BY c" and "(SELECT ... LIMIT n) ORDER BY c" fail with
+ * UnsupportedOperationException</a>.
+ *
+ * <p>{@code SqlOrderBy} lacked a {@code setOperand} override, so
Review Comment:
In general comments about what is no longer around are of limited usefulness
except for the current reviewer. I would remove them.
##########
core/src/main/java/org/apache/calcite/sql/SqlOrderBy.java:
##########
@@ -41,10 +41,10 @@ public class SqlOrderBy extends SqlCall {
}
};
- public final SqlNode query;
- public final SqlNodeList orderList;
- public final @Nullable SqlNode offset;
- public final @Nullable SqlNode fetch;
+ public SqlNode query;
Review Comment:
This seems to be similar to other SqlCall extension classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
