vlsi commented on PR #5283: URL: https://github.com/apache/calcite/pull/5283#issuecomment-5809808066
The updated description is better: * The first sentence in "Why" clarifies everything. From my point of view it makes a huge difference. * I think "what" section is excessively large. There's no point in those ascii-charts. A mere "reuse input operand list and create a new only when at least one operand changes" would probably do. * I'm not sure listing "I ran tests, I ran autostyle" adds value. We have CI for that. I would prefer "verification" to include "targeted" information for the PR. For instance, it could be "here's a test I added, here are Calcite benchmark results. PS. The PR still misses calcite-level tests, and calcite-level benchmarks. If the PR had those tests, the description could be way better. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
