FrankChen021 commented on PR #5283: URL: https://github.com/apache/calcite/pull/5283#issuecomment-5855514934
@vlsi Thanks for the detailed review. I have addressed your above comments. Could you please take another look? The benchmark now includes `VARCHAR = SOME(ARRAY[...])`. It shows a 1.28% end-to-end allocation reduction, smaller than the Druid result because the Druid planning pipeline exercises the optimized traversal more extensively. The unchanged traversal improves substantially, while the changed-operand path shows no material regression. @julianhyde You mentioned this PR in the mailing-list discussion. The change is limited to making operand copying lazy, with tests covering unchanged operands, changed operands, and alwaysCopy. If you have additional concrete scenarios or benchmarks you would like covered, please let me know. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
