sbroeder commented on code in PR #5297:
URL: https://github.com/apache/calcite/pull/5297#discussion_r4243910216
##########
core/src/main/java/org/apache/calcite/sql/validate/implicit/AbstractTypeCoercion.java:
##########
@@ -495,8 +495,25 @@ private RelDataType getTightestCommonTypeOrThrow(
/**
* Determines common type for a comparison operator.
- * For date and timestamp operands, use timestamp as common type,
- * i.e. Timestamp(2017-01-01 00:00 ...) > Date(2018) evaluates to be
false.
+ *
+ * <p>For date and timestamp operands, uses timestamp as common type,
+ * i.e. {@code Timestamp(2017-01-01 00:00 ...) > Date(2018)} evaluates to
false.
+ *
+ * <p>Comparing an approximate numeric ({@code REAL}, {@code DOUBLE}) with
Review Comment:
Done — FLOAT added, wording hardened, MULTISET removed with note it returns
ARRAY type
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
