sbroeder commented on PR #5297: URL: https://github.com/apache/calcite/pull/5297#issuecomment-6115797985
> No test covers `NATURAL JOIN` or `JOIN USING` under the override, although the `TypeCoercion` javadoc and `reference.md` single them out as the path where `SqlToRelConverter` calls `commonTypeForBinaryComparison` itself. `testJoinOnDecimalEqualsRealWithCustomTypeCoercion` uses `ON d.k = f.k`, which goes through `binaryComparisonCoercion` in the validator instead. A copy of that test with `USING (k)` would cover the other path; the plan shows whether both columns are cast to DOUBLE. Added test as suggested -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
