gianm commented on PR #5349: URL: https://github.com/apache/calcite/pull/5349#issuecomment-6545016652
> Please, you amend your commit on a 2.3KLOC PR? How am I supposed to find out what you changed? Now I have to read everything again? Maybe you can dig your history and make the changes as a separate commit. I updated the branch to be the commit you originally reviewed + the follow up as a separate commit. I also merged in `main`, which was needed to fix one of the tests. This approach (follow-up commits, merging `main` when needed, no force pushes) is more what I am accustomed to doing in other repos. And, sorry, I had got confused about how things work around here. Originally I tried doing a second commit and it ran afoul of the LintTest. I looked around at what people were doing in other recent PRs, and generally saw force pushing happening, so I figured that it was standard here to avoid having multiple commits on a branch. Looking closer I now see that the LintTest just wants follow up commit messages to be formatted a certain way. Blame trying to get CI working at the end of the day. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
