omarsmak commented on a change in pull request #4877:
URL: https://github.com/apache/camel/pull/4877#discussion_r557262208
##########
File path:
components/camel-google-pubsub/src/main/java/org/apache/camel/component/google/pubsub/GooglePubsubComponent.java
##########
@@ -129,6 +132,15 @@ private Publisher buildPublisher(String topicName) throws
IOException {
CredentialsProvider credentialsProvider =
NoCredentialsProvider.create();
builder.setChannelProvider(channelProvider).setCredentialsProvider(credentialsProvider);
}
+ if (googlePubsubEndpoint.isMessageOrderingEnabled()) {
+ builder.setEnableMessageOrdering(true);
+ if
(StringHelper.trimToNull(googlePubsubEndpoint.getPubsubEndpoint()) != null) {
+ builder.setEndpoint(googlePubsubEndpoint.getPubsubEndpoint());
Review comment:
I see. My problem here is that, we will end up with two similar endpoint
options which could be a bit confusing to the user. Hence, can we somehow
refactor this to only have one endpoint option to be overriden (emulator and
API endpoint)? Also, I don't think overriding the endpoint should be only
possible when the message ordering is enabled.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
