omarsmak commented on a change in pull request #4877:
URL: https://github.com/apache/camel/pull/4877#discussion_r557290700



##########
File path: 
components/camel-google-pubsub/src/main/java/org/apache/camel/component/google/pubsub/GooglePubsubComponent.java
##########
@@ -129,6 +132,15 @@ private Publisher buildPublisher(String topicName) throws 
IOException {
             CredentialsProvider credentialsProvider = 
NoCredentialsProvider.create();
             
builder.setChannelProvider(channelProvider).setCredentialsProvider(credentialsProvider);
         }
+        if (googlePubsubEndpoint.isMessageOrderingEnabled()) {
+            builder.setEnableMessageOrdering(true);
+            if 
(StringHelper.trimToNull(googlePubsubEndpoint.getPubsubEndpoint()) != null) {
+                builder.setEndpoint(googlePubsubEndpoint.getPubsubEndpoint());

Review comment:
       Okay, then for now we can just enabling the endpoint override without 
the message ordering. And then later we can do the endpoint refactor (to have 
only one endpoint option to configure instead of two). Would be great if you 
can create a JIRA for the proposed improvement. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to