phantomjinx commented on a change in pull request #2284: URL: https://github.com/apache/camel-k/pull/2284#discussion_r648088680
########## File path: config/infrastructure/rbac/kubernetes/builder-role-binding-kubernetes.yaml ########## @@ -0,0 +1,30 @@ +# --------------------------------------------------------------------------- +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# --------------------------------------------------------------------------- + +kind: RoleBinding +apiVersion: rbac.authorization.k8s.io/v1 +metadata: + name: camel-k-builder-kubernetes + labels: Review comment: The suffixes of "-openshift" and "-kubernetes" became necessary from a practical step that 2 bindings cannot have the same name. If kustomize encounters 2 resources of the same kind with the same name it results in an error. In some cases, the openshift and kubernetes resources are mutually exclusive and thus only 1 or the other is required to be applied. However, in other cases, the openshift version simply adds extra permissions to the 'base' kubernetes version. Therefore, - need to decide if openshift resources should duplicate kubernetes content and so only 1 or the other is installed. This would make suffixing resources unnecessary; - if openshift resources provide extra openshift-specific content only and so require the kubernetes resource as a base. This would require the suffixing of resource names. My personal preference is the latter as I am not a fan of duplication and I think making it obvious to the user that such permissions and bindings affect only a specific cluster type is transparent and informative. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
