phantomjinx commented on a change in pull request #2284:
URL: https://github.com/apache/camel-k/pull/2284#discussion_r648094290
##########
File path: config/rbac/kubernetes/operator-role-binding-events.yaml
##########
@@ -21,6 +21,8 @@ metadata:
name: camel-k-operator-events
labels:
app: "camel-k"
+ annotations:
+ can-promote: "true"
Review comment:
This identifies which resources can be promoted to the cluster level.
There are indeed exceptions which remain roles and rolebindings. The kustomize
patch functionality uses a selector on the annotation to identify which
resources to patch, I have not come across a negation function that will detect
those that should be excluded.
If the annotation is not appropriate then a list of names will have to be
added to the `kustomize.yaml`. This was my first attempt and proved cumbersome
and prone to errors (kept forgetting the strimzi role for some reason!).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
