lburgazzoli commented on a change in pull request #2540:
URL: https://github.com/apache/camel-k/pull/2540#discussion_r681077808
##########
File path: pkg/trait/logging.go
##########
@@ -90,8 +90,12 @@ func (l loggingTrait) Apply(environment *Environment) error {
if util.IsTrue(l.JsonPrettyPrint) {
envvar.SetVal(&environment.EnvVars,
envVarQuarkusLogConsoleJsonPrettyPrint, True)
}
- } else if util.IsNilOrTrue(l.Color) {
- envvar.SetVal(&environment.EnvVars,
envVarQuarkusLogConsoleColor, True)
+ } else {
+ envvar.SetVal(&environment.EnvVars,
envVarQuarkusLogConsoleJson, False)
Review comment:
I don0t have any strong opinion here and both solution are fine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
