orpiske commented on a change in pull request #2540:
URL: https://github.com/apache/camel-k/pull/2540#discussion_r681131159
##########
File path: pkg/trait/logging.go
##########
@@ -90,8 +90,12 @@ func (l loggingTrait) Apply(environment *Environment) error {
if util.IsTrue(l.JsonPrettyPrint) {
envvar.SetVal(&environment.EnvVars,
envVarQuarkusLogConsoleJsonPrettyPrint, True)
}
- } else if util.IsNilOrTrue(l.Color) {
- envvar.SetVal(&environment.EnvVars,
envVarQuarkusLogConsoleColor, True)
+ } else {
+ envvar.SetVal(&environment.EnvVars,
envVarQuarkusLogConsoleJson, False)
Review comment:
@astefanutti @lburgazzoli thanks guys. So, let's go with this as a
work-around for now.
Antonin's raised a good point here and I think I can take a look at solving
this when I cleanup/refactor for #2541. At the very least this gives us some
time to think about it and consider the approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
