tadayosi commented on a change in pull request #2766:
URL: https://github.com/apache/camel-k/pull/2766#discussion_r755685485
##########
File path: .golangci.yml
##########
@@ -18,54 +18,46 @@
linters-settings:
lll:
line-length: 170
+ goconst:
+ ignore-tests: true
linters:
- disable-all: true
- enable:
- - asciicheck
- - bodyclose
- - deadcode
- - depguard
- - dogsled
- - durationcheck
- - errcheck
- - errname
- - errorlint
- - exportloopref
- - forcetypeassert
- - gocritic
- - gofmt
+ enable-all: true
Review comment:
I changed in a previous commit here from enable-all (denylisting) to
disable-all (allowlisting), because otherwise every time we try to upgrade
golangci-lint it will introduce a new set of linters which weren't checked
before and thus upgrading golangci-lint will become painful. I thought using
`disable-all` and allowlisting makes upgrading the golangci-lint action easier.
So, do you think it's not a good idea and we should catch up with new
additions to linters along with upgrade of the action?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
