astefanutti commented on a change in pull request #2766:
URL: https://github.com/apache/camel-k/pull/2766#discussion_r755779181
##########
File path: .golangci.yml
##########
@@ -18,54 +18,46 @@
linters-settings:
lll:
line-length: 170
+ goconst:
+ ignore-tests: true
linters:
- disable-all: true
- enable:
- - asciicheck
- - bodyclose
- - deadcode
- - depguard
- - dogsled
- - durationcheck
- - errcheck
- - errname
- - errorlint
- - exportloopref
- - forcetypeassert
- - gocritic
- - gofmt
+ enable-all: true
Review comment:
On one hand with `disable-all`, it's less work to upgrade, but we would
lag behind what would be the "default" / de-facto standard set of linters, and
we would create a "debt" over time that would have to be pay by some larger
one-time efforts, on the other hand with `enable-all`, there is some extra work
possible each time we upgrade, which may biased us from not upgrading, but we
would inherit from the "default", possibly better set of linters.
I'd be inclined toward trusting `golangci-lint` and trying with
`enable-all`, so we dilute the possible overhead, keeping in mind that we can
always revert to `disable-all` if that does not work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
