aldettinger commented on code in PR #3919:
URL: https://github.com/apache/camel-quarkus/pull/3919#discussion_r939996294
##########
integration-tests/google-pubsub/src/main/java/org/apache/camel/quarkus/component/google/pubsub/it/GooglePubsubResource.java:
##########
@@ -64,7 +82,95 @@ public Response sendPojoToTopic(String fruitName) {
@Produces(MediaType.APPLICATION_JSON)
public Response consumePojoFromTopic() {
Object response = consumerTemplate
-
.receiveBody("google-pubsub:{{project.id}}:{{subscription.name}}?synchronousPull=true",
5000L);
+
.receiveBody("google-pubsub:{{project.id}}:{{google-pubsub.subscription-name}}?synchronousPull=false",
5000L);
return Response.ok(response).build();
}
+
+ @Path("/sendToEndpoint")
+ @POST
+ public Response sentToEndpoint(String message,
+ @QueryParam("toEndpoint") String toEndpoint)
+ throws Exception {
+ producerTemplate.sendBody(toEndpoint, message);
+ return
Response.created(URI.create("https://camel.apache.org";)).build();
+ }
+
+ @Path("/getFromEndpoint")
+ @GET
+ @Produces(MediaType.TEXT_PLAIN)
+ public String getSchedulerResult(@QueryParam("fromEndpoint") String
fromEndpoint) throws Exception {
+ return consumerTemplate.receiveBody(fromEndpoint, 5000, String.class);
+ }
+
+ @Path("receive/subscription/{subscriptionName}")
+ @GET
+ @Produces(MediaType.TEXT_PLAIN)
+ public String receiveFromSubscription(@PathParam("subscriptionName")
String subscriptionName) throws Exception {
+ return consumeEndpoint(subscriptionName, null);
+ }
+
+ @Path("receive/subscriptionOrdering/{subscriptionName}")
+ @GET
+ @Produces(MediaType.TEXT_PLAIN)
+ public String
receiveFromSubscriptionOrdered(@PathParam("subscriptionName") String
subscriptionName) throws Exception {
+
+ return consumeEndpoint(subscriptionName,
+
"?messageOrderingEnabled=true&pubsubEndpoint=us-east1-pubsub.googleapis.com:443");
Review Comment:
The documentation mention 3 reasons for using regional endpoints. In this
PR, my understanding is that we deal with small volumes, producers/subscribers
in same region, without constraints on data locality. If one agree with this,
then it would be tempting to use global so that tests run on a nearby available
region. Maybe tests would run quicker and fail less frequently.
That said, it may not be that simple. Maybe we could try global and
integrate in the PR only of it works straight forward ? Maybe it's the subject
of another ticket ? Or maybe requesting to the global endpoint is not a good
idea for some reasons ?
What do you think ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
