squakez commented on code in PR #3828:
URL: https://github.com/apache/camel-k/pull/3828#discussion_r1027716411
##########
pkg/util/command_test.go:
##########
@@ -56,5 +57,9 @@ func TestRunAndLogInvalid(t *testing.T) {
err := RunAndLog(context.Background(), cmd, loggerInfo, loggerError)
assert.NotNil(t, err)
- assert.ErrorContains(t, err, "exit status 1")
+ if runtime.GOOS == "darwin" {
+ assert.ErrorContains(t, err, "exit status 1")
Review Comment:
I'd prefer to have a switch here to test linux ("date: invalid date ‘sa’"),
darwin (we should understand which is the output there) and else any other
platform (ie, windows, with generic "exit status 1").
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
