squakez commented on code in PR #3828:
URL: https://github.com/apache/camel-k/pull/3828#discussion_r1031209420
##########
pkg/util/command_test.go:
##########
@@ -56,5 +57,9 @@ func TestRunAndLogInvalid(t *testing.T) {
err := RunAndLog(context.Background(), cmd, loggerInfo, loggerError)
assert.NotNil(t, err)
- assert.ErrorContains(t, err, "exit status 1")
+ if runtime.GOOS == "darwin" {
+ assert.ErrorContains(t, err, "exit status 1")
Review Comment:
Interesting. For some reason, in `darwin` we are not returning the error
trace as it happens in `linux`. The test was good, but the failure shows us
that maybe the implementation does not do what it is expected to do. If you
notice the execution of the command returns `: exit status 1`, like it miss to
capture the expected output `date: illegal option -- d`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
