claudio4j commented on code in PR #4729:
URL: https://github.com/apache/camel-k/pull/4729#discussion_r1322044474
##########
pkg/trait/knative_service.go:
##########
@@ -175,6 +178,8 @@ func (t *knativeServiceTrait) getServiceFor(e *Environment)
(*serving.Service, e
for k, v := range e.Integration.Annotations {
serviceAnnotations[k] = v
Review Comment:
It seems the current behavior to set the annotations in the integration and
they are propagated to the knative service is actually right, isn't ?
If the user sets the knative service route annotation, then the integration
annotations are not propagated to the knative service, which is not backward
compatible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]