realMartinez commented on code in PR #4729:
URL: https://github.com/apache/camel-k/pull/4729#discussion_r1324336695
##########
pkg/trait/knative_service_test.go:
##########
@@ -512,3 +514,26 @@ func createKnativeServiceTestEnvironment(t *testing.T,
trait *traitv1.KnativeSer
return environment
}
+func TestServiceAnnotation(t *testing.T) {
+ annotationsTest :=
map[string]string{"haproxy.router.openshift.io/balance": "true"}
+
+ environment := createTestRouteEnvironment(t, KnativeServiceTestName)
+ environment.Integration.Spec.Traits = v1.Traits{
+ Route: &traitv1.RouteTrait{
Review Comment:
> Why are you testing Route annotation? I think you need to test
`KnativeServiceTrait` instead.
You are right I made a mistake here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
