anton-goncharov commented on code in PR #11934:
URL: https://github.com/apache/camel/pull/11934#discussion_r1386766506
##########
core/camel-core/src/test/java/org/apache/camel/component/file/FileConsumerFailureHandledTest.java:
##########
@@ -57,7 +57,7 @@ public void testLondon() throws Exception {
mock.expectedBodiesReceived("London");
template.sendBodyAndHeader(fileUri(), "London", Exchange.FILE_NAME,
"london.txt");
- mock.assertIsSatisfied(1000);
+ mock.assertIsSatisfied(3000);
Review Comment:
I couldn't find another explanation why this test has failed on a previous
PR check run, as locally it passes when I run all camel-core tests. The same I
see now but with other tests. After this change of timeout, this
`FileConsumerFailureHandledTest` passes but two others fail:
-
`org.apache.camel.processor.MulticastParallelTimeoutStreamCachingTest.testCreateOutputStreamCacheBeforeTimeoutButWriteToOutputStreamCacheAfterTimeout`
-
`org.apache.camel.processor.MulticastParallelStreamingTest.testMulticastParallel`
Both don't use temp directory anyhow and shouldn't be affected by my
changes, so I'm wondering how stable such tests are. I'm very new to it so I'm
trying to understand if it's something that can happen ocassionally due to
slower test execution, or if it's related to my PR changes. I apologize for my
confusion as someone new, but really appreciate your guidance and open to
suggestions 🙂
##########
core/camel-core/src/test/java/org/apache/camel/component/file/FileConsumerFailureHandledTest.java:
##########
@@ -57,7 +57,7 @@ public void testLondon() throws Exception {
mock.expectedBodiesReceived("London");
template.sendBodyAndHeader(fileUri(), "London", Exchange.FILE_NAME,
"london.txt");
- mock.assertIsSatisfied(1000);
+ mock.assertIsSatisfied(3000);
Review Comment:
I couldn't find another explanation why this test has failed on a previous
PR check run, as locally it passes when I run all camel-core tests. The same I
see now but with other tests. After this change of timeout, this
`FileConsumerFailureHandledTest` passes but two others fail:
-
`org.apache.camel.processor.MulticastParallelTimeoutStreamCachingTest.testCreateOutputStreamCacheBeforeTimeoutButWriteToOutputStreamCacheAfterTimeout`
-
`org.apache.camel.processor.MulticastParallelStreamingTest.testMulticastParallel`
Both don't use temp directory anyhow and shouldn't be affected by my
changes, so I'm wondering how stable such tests are. I'm very new to it so I'm
trying to understand if it's something that can happen ocassionally due to
slower test execution, or if it's related to my PR changes. I apologize for my
confusion as someone new, but really appreciate your guidance and open to
suggestions 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
