orpiske commented on code in PR #11934:
URL: https://github.com/apache/camel/pull/11934#discussion_r1387733384
##########
core/camel-core/src/test/java/org/apache/camel/component/file/FileConsumerFailureHandledTest.java:
##########
@@ -57,7 +57,7 @@ public void testLondon() throws Exception {
mock.expectedBodiesReceived("London");
template.sendBodyAndHeader(fileUri(), "London", Exchange.FILE_NAME,
"london.txt");
- mock.assertIsSatisfied(1000);
+ mock.assertIsSatisfied(3000);
Review Comment:
So, the challenge here is that we have to balance two things:
1. Quick test execution
2. Stability
In some of the systems where these tests run, such as GitHub, the systems
running them could be overloaded at the time of execution. Some tests use fixed
sleeps and/or timeouts to wait for "something" to happen, but this process is
not stable at all (hence, why we have been converting most of the sleeps with
Awaitility).
I suspect that's why you see these new failures: maybe if you run them
again, you'll see a different set of failures.
Normally, what we do is that we use the [ASF
CI](https://ci-builds.apache.org/job/Camel/job/Camel%20JDK17/) as the baseline:
as long as tests run fine there, we are OK with it (and we are a bit lenient
with [most of] the core check failures on GitHub).
So, in this case, I'd leave it as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
