davsclaus commented on code in PR #992:
URL: https://github.com/apache/camel-karavan/pull/992#discussion_r1394594049
##########
karavan-web/karavan-app/src/main/java/org/apache/camel/karavan/service/ProjectService.java:
##########
@@ -187,34 +187,38 @@ public Project save(Project project) throws Exception {
}
public Project copy(String sourceProjectId, Project project) throws
Exception {
+ boolean isNew = infinispanService.getProject(project.getProjectId())
== null;
Project sourceProject = infinispanService.getProject(sourceProjectId);
+
// Save project
infinispanService.saveProject(project);
- // Copy files from the source and make necessary modifications
- Map<GroupedKey, ProjectFile> filesMap =
infinispanService.getProjectFilesMap(sourceProjectId).entrySet().stream()
- .filter(e -> !Objects.equals(e.getValue().getName(),
PROJECT_COMPOSE_FILENAME) &&
- !Objects.equals(e.getValue().getName(),
PROJECT_DEPLOYMENT_JKUBE_FILENAME)
- )
- .collect(Collectors.toMap(
- e -> new GroupedKey(project.getProjectId(),
e.getKey().getEnv(), e.getKey().getKey()),
- e -> {
- ProjectFile file = e.getValue();
- file.setProjectId(project.getProjectId());
- if(Objects.equals(file.getName(),
APPLICATION_PROPERTIES_FILENAME)) {
- modifyPropertyFileOnProjectCopy(file,
sourceProject, project);
- }
- return file;
- })
- );
- infinispanService.saveProjectFiles(filesMap);
-
- if (!ConfigService.inKubernetes()) {
- ProjectFile projectCompose =
codeService.createInitialProjectCompose(project);
- infinispanService.saveProjectFile(projectCompose);
- } else if (kubernetesService.isOpenshift()){
- ProjectFile projectCompose =
codeService.createInitialDeployment(project);
- infinispanService.saveProjectFile(projectCompose);
+ if(isNew) {
Review Comment:
We use space after if, eg if (xxx)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
