mvolf commented on code in PR #992:
URL: https://github.com/apache/camel-karavan/pull/992#discussion_r1400553456
##########
karavan-web/karavan-app/src/main/webui/src/api/ProjectService.ts:
##########
@@ -258,7 +258,6 @@ export class ProjectService {
public static copyProject(sourceProject: string, project: Project) {
KaravanApi.copyProject(sourceProject, project, res => {
if (res.status === 200 || res.status === 201) {
- EventBus.sendAlert( 'Success', 'Project copied', 'success');
Review Comment:
@mgubaidullin Because with the current implementation it will get triggered
even if the project doesn't actually get copied (because user sent an existing
project-id) and this is a very confusing UX. That's why I mentioned that the
best approach would be to have a UI validation, but that's a much bigger task
and this was a quick fix to avoid issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
