lburgazzoli commented on code in PR #5186:
URL: https://github.com/apache/camel-k/pull/5186#discussion_r1503792088
##########
pkg/apis/camel/v1/knative/types.go:
##########
@@ -38,6 +38,7 @@ type CamelServiceDefinition struct {
URL string `json:"url,omitempty"`
Path string `json:"path,omitempty"`
Metadata map[string]string `json:"metadata,omitempty"`
+ SinkBinding bool `json:"sinkBinding,omitempty"`
Review Comment:
Wonder if we really need this or we can set the url and overrides when the
service definition is created so we won't need any particular if/then/else
later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
