squakez commented on code in PR #5186:
URL: https://github.com/apache/camel-k/pull/5186#discussion_r1503809358
##########
pkg/apis/camel/v1/knative/types.go:
##########
@@ -38,6 +38,7 @@ type CamelServiceDefinition struct {
URL string `json:"url,omitempty"`
Path string `json:"path,omitempty"`
Metadata map[string]string `json:"metadata,omitempty"`
+ SinkBinding bool `json:"sinkBinding,omitempty"`
Review Comment:
I think we need this because the way the logic is defined right now. At a
first iteration we select the services. At a second iteration we apply the
configuration setting. I think it is cleaner to mark this particular service as
a SinkBinding, letting the object to know how to configure later when
deserialize, instead of having the controller to assume this logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
