squakez commented on code in PR #5275:
URL: https://github.com/apache/camel-k/pull/5275#discussion_r1537236203
##########
pkg/trait/knative.go:
##########
@@ -70,7 +71,8 @@ func (t *knativeTrait) Configure(e *Environment) (bool,
*TraitCondition, error)
if e.Integration == nil {
return false, nil, nil
}
- if !pointer.BoolDeref(t.Enabled, true) {
Review Comment:
But I think that's exactly what `!pointer.BoolDeref(t.Enabled, true)` does.
If the user does not set explicitly to `false`, then it is always `true`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
