squakez commented on code in PR #1559:
URL:
https://github.com/apache/camel-spring-boot/pull/1559#discussion_r2490674288
##########
components-starter/camel-observation-starter/src/main/java/org/apache/camel/observation/starter/ObservationAutoConfiguration.java:
##########
@@ -25,17 +25,20 @@
import org.apache.camel.CamelContext;
import org.apache.camel.observation.MicrometerObservationTracer;
import org.springframework.beans.factory.ObjectProvider;
-import
org.springframework.boot.actuate.autoconfigure.tracing.MicrometerTracingAutoConfiguration;
import org.springframework.boot.autoconfigure.AutoConfigureAfter;
import
org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean;
+import
org.springframework.boot.autoconfigure.condition.ConditionalOnMissingClass;
import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty;
import
org.springframework.boot.context.properties.EnableConfigurationProperties;
import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.Configuration;
@Configuration(proxyBeanMethods = false)
-@AutoConfigureAfter(value =
- {
org.springframework.boot.actuate.autoconfigure.observation.ObservationAutoConfiguration.class,
MicrometerTracingAutoConfiguration.class})
+@ConditionalOnMissingClass({
"org.springframework.boot.actuate.autoconfigure.observation.ObservationAutoConfiguration",
Review Comment:
Not sure if this would affect the fix we did for
https://issues.apache.org/jira/browse/CAMEL-22612 - why is it required?
##########
components-starter/camel-observation-starter/src/main/java/org/apache/camel/observation/starter/ObservationAutoConfiguration.java:
##########
@@ -25,17 +25,20 @@
import org.apache.camel.CamelContext;
import org.apache.camel.observation.MicrometerObservationTracer;
import org.springframework.beans.factory.ObjectProvider;
-import
org.springframework.boot.actuate.autoconfigure.tracing.MicrometerTracingAutoConfiguration;
import org.springframework.boot.autoconfigure.AutoConfigureAfter;
import
org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean;
+import
org.springframework.boot.autoconfigure.condition.ConditionalOnMissingClass;
import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty;
import
org.springframework.boot.context.properties.EnableConfigurationProperties;
import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.Configuration;
@Configuration(proxyBeanMethods = false)
-@AutoConfigureAfter(value =
- {
org.springframework.boot.actuate.autoconfigure.observation.ObservationAutoConfiguration.class,
MicrometerTracingAutoConfiguration.class})
+@ConditionalOnMissingClass({
"org.springframework.boot.actuate.autoconfigure.observation.ObservationAutoConfiguration",
+
"org.springframework.boot.actuate.autoconfigure.tracing.MicrometerTracingAutoConfiguration"
})
+@AutoConfigureAfter(name = {
Review Comment:
Okey, I changed because I thought it was more consistent to leverage on a
class instead of a string which will be converted to a class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
