Croway commented on code in PR #1559:
URL:
https://github.com/apache/camel-spring-boot/pull/1559#discussion_r2490728177
##########
components-starter/camel-observation-starter/src/main/java/org/apache/camel/observation/starter/ObservationAutoConfiguration.java:
##########
@@ -25,17 +25,20 @@
import org.apache.camel.CamelContext;
import org.apache.camel.observation.MicrometerObservationTracer;
import org.springframework.beans.factory.ObjectProvider;
-import
org.springframework.boot.actuate.autoconfigure.tracing.MicrometerTracingAutoConfiguration;
import org.springframework.boot.autoconfigure.AutoConfigureAfter;
import
org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean;
+import
org.springframework.boot.autoconfigure.condition.ConditionalOnMissingClass;
import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty;
import
org.springframework.boot.context.properties.EnableConfigurationProperties;
import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.Configuration;
@Configuration(proxyBeanMethods = false)
-@AutoConfigureAfter(value =
- {
org.springframework.boot.actuate.autoconfigure.observation.ObservationAutoConfiguration.class,
MicrometerTracingAutoConfiguration.class})
+@ConditionalOnMissingClass({
"org.springframework.boot.actuate.autoconfigure.observation.ObservationAutoConfiguration",
Review Comment:
it is required because without spring actuator dependency (it is optional in
the components starter pom.xml, which is fine),
`org.springframework.boot.actuate.autoconfigure.observation.ObservationAutoConfiguration`
class is not present in the classpath. therefore, let's disable
autoconfiguration if the spring actuator is not on the class path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
