squakez commented on code in PR #22343:
URL: https://github.com/apache/camel/pull/22343#discussion_r3010559773
##########
components/camel-salesforce/camel-salesforce-component/src/main/java/org/apache/camel/component/salesforce/SalesforceComponent.java:
##########
@@ -958,6 +958,7 @@ public RawClient createRawClientFor(SalesforceEndpoint
endpoint) throws Salesfor
return new DefaultRawClient(httpClient, "", session, loginConfig);
}
+ @SuppressWarnings("java:S2095") // ExecutorService lifecycle is managed by
SalesforceHttpClient
Review Comment:
Adding the note at method level can include future maintenance problems if,
for example, in the future the method includes a real connection leak which
won't be notified as we're suppress warning at this level. IMO, these kinds of
notes should be added at line level. If you check the rest of the code, the
majority of time we're adding a`// NOSONAR` line on the affected line and above
it another comment note explaining why this specific line should not appear in
the sonar lint.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
