gnodet commented on code in PR #22343:
URL: https://github.com/apache/camel/pull/22343#discussion_r3010740979
##########
pom.xml:
##########
@@ -122,6 +122,7 @@
<!-- NOTE: this is required to correctly map each module coverage in
Sonarqube. The ${maven.multiModuleProjectDirectory} may require some change
when upgrading to Maven 4.x, according to any of the new variables
that will replace this one. -->
+ <sonar.java.source>${jdk.version}</sonar.java.source>
<sonar.coverage.jacoco.xmlReportPaths>
${maven.multiModuleProjectDirectory}/coverage/target/site/jacoco-aggregate/jacoco.xml
</sonar.coverage.jacoco.xmlReportPaths>
Review Comment:
Good point — moved `sonar.java.source` above the NOTE comment so it stays
directly above `sonar.coverage.jacoco.xmlReportPaths` where it belongs. Also
added a separate comment for `sonar.java.source`. Fixed in 9271179.
_Claude Code on behalf of Guillaume Nodet_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
