code-massel commented on PR #22769: URL: https://github.com/apache/camel/pull/22769#issuecomment-4397542854
Thanks for the second round of feedback — all items addressed and pushed (10bd777b303). **Test class fixes:** 1. Replaced `Thread.sleep(100)` in `testSyncRetryInterrupted` with `Awaitility.await().atMost(5s).until(() -> interruptCounter.get() > 0)` — no more timing-dependent sleep before interrupt. 2. Replaced conditional `if (aggregateThreadName != null)` and `if (result != null && ...)` assertions with `assertNotNull(...)` + unconditional assertions — tests now actually fail if the core behavior is not exercised. 3. Removed `public` from class and all test methods — now package-private, consistent with `AggregateCompletionOnlyTwoTest` and others in the same package. 4. Removed unused `callerThread` variable in `testSyncRetryHappensInSameThread`. **Missing generated file:** `camelYamlDsl-canonical.json` was not present on the branch because the file was added to `main` after the branch was created. Rebased the branch onto current `main` and regenerated — the file now includes the `optimisticLockingSyncRetry` option (6 insertions). All 4 tests pass locally. Let me know if there is anything else to address. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
