jamesnetherton commented on code in PR #24065:
URL: https://github.com/apache/camel/pull/24065#discussion_r3427170130
##########
dsl/camel-yaml-dsl/camel-yaml-dsl-common/src/main/java/org/apache/camel/dsl/yaml/common/YamlDeserializationContext.java:
##########
@@ -120,14 +141,204 @@ protected Optional<ConstructNode>
findConstructorFor(Node node) {
@Override
public void start() {
+ loadResolvers();
+ }
+
+ private void loadResolvers() {
ObjectHelper.notNull(camelContext, "camel context");
-
this.resolvers.addAll(getCamelContext().getRegistry().findByType(YamlDeserializerResolver.class));
+ if (resolversLoaded) {
+ return;
+ }
+
+ addResolverEntries(loadResolversFromClasspath());
Review Comment:
> Introduce a Camel-owned discovery/provider SPI, for example
YamlDeserializerResolverProvider, registered as a Camel context plugin
That sounds ok. Lets follow that direction.
I can always follow with future PRs if additional tweaks are needed for CQ.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
