oscerd commented on PR #24196: URL: https://github.com/apache/camel/pull/24196#issuecomment-4778156233
Thanks for the review and approval, @davsclaus. On the two non-blocking suggestions: 1. **Filter caching** — `HttpHelper.resolveDeserializationFilter` is a stateless static helper shared by both the consumer (`DefaultHttpBinding`) and the producer (`HttpProducer`), so unlike `JmsBinding` there's no single binding instance to cache a `final` field on. `ObjectInputFilter.Config.createFilter(...)` only runs on the opt-in `allowJavaSerializedObject` / `transferException` path (rare), so as you noted the overhead is negligible — I've kept the helper stateless rather than thread a cached `ObjectInputFilter` through the API. Glad to revisit it together with the shared-utility refactor below. 2. **Shared utility** — agreed: `DEFAULT_DESERIALIZATION_FILTER` + `resolveDeserializationFilter()` now live in `HttpHelper`, `NettyHttpHelper` / `NettyConverter`, `VertxHttpHelper` and `JmsBinding`, and consolidating them into `camel-support` would reduce the duplication (and would be the right place to also unify the `camel-jms` default per @gnodet's comment). I'd prefer to do that as a separate follow-up rather than widen this PR's scope. _Claude Code on behalf of Andrea Cosentino_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
