oscerd commented on code in PR #24196:
URL: https://github.com/apache/camel/pull/24196#discussion_r3458871158
##########
components/camel-http-common/src/main/java/org/apache/camel/http/common/HttpHelper.java:
##########
@@ -40,9 +41,23 @@
import org.apache.camel.util.IOHelper;
import org.apache.camel.util.URISupport;
import org.apache.camel.util.UnsafeUriCharactersEncoder;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
public final class HttpHelper {
+ /**
Review Comment:
Thanks for the careful look. I double-checked the sibling defaults, and the
JEP-290 graph-shape limits are in fact present in the two HTTP siblings — so
this is deliberately aligned rather than divergent:
- **camel-netty-http** — `NettyHttpHelper.DEFAULT_DESERIALIZATION_FILTER` =
`!java.net.**;java.**;javax.**;org.apache.camel.**;maxdepth=20;maxrefs=10000;maxbytes=10485760;!*`
- **camel-vertx-http** — `VertxHttpHelper` — identical, with the limits
- **camel-netty** — `NettyConverter` — identical, with the limits
- **camel-jms** — `JmsBinding` is the only one that omits them
(`…org.apache.camel.**;!*`)
So `camel-http-common` now matches the HTTP-stream siblings (netty-http /
vertx-http) exactly; the only difference is from `camel-jms`, which reads from
a broker rather than a raw network socket where the graph-shape limits matter
most. The inclusion here is intentional and consistent with the components
that, like this one, deserialize from network streams. Happy to unify the
`camel-jms` default into the same pattern in a follow-up if we'd prefer a
single shared default everywhere.
_Claude Code on behalf of Andrea Cosentino_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
