gnodet opened a new pull request, #24855:
URL: https://github.com/apache/camel/pull/24855

   ## Summary
   
   Fix 27 SonarCloud BLOCKER issues (rule S2699: tests should include 
assertions) across 22 test files in `core/camel-core`.
   
   All flagged methods are smoke tests that verify operations complete without 
throwing exceptions but lacked explicit JUnit assertions. The fix wraps test 
bodies in `assertDoesNotThrow()` or adds `assertTrue()` as appropriate.
   
   ### Fixed test categories:
   - **UUID generator performance tests** (5 files): `testPerformance()` 
methods generating 500K+ UUIDs
   - **Configuration validation tests** (3 files): "valid config should not 
throw" counterparts to `assertThrows` tests
   - **Route lifecycle tests** (4 files): adviceWith, onException, health 
check, deadlock detection
   - **I/O and utility tests** (4 files): IOHelper, InetAddress, XmlConverter, 
file operations
   - **Miscellaneous smoke tests** (6 files): MDC, tracing, async templates, 
Issue3
   
   ### Changes per file:
   | File | Methods fixed | Fix type |
   |---|---|---|
   | `OnExceptionMisconfiguredTest` | 5 | `assertDoesNotThrow` |
   | UUID generators (5 files) | 5 | `assertDoesNotThrow` |
   | `ThreadsInvalidConfigTest` | 2 | `assertDoesNotThrow` |
   | `VirtualThreadsLoadTest` | 1 | `assertTrue(completed, ...)` |
   | Others (10 files) | 14 | `assertDoesNotThrow` |
   
   ## Test plan
   - [x] All 22 modified test files pass locally (135 tests, 0 failures)
   - [ ] CI passes
   
   _Claude Code on behalf of Guillaume Nodet_
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to