gnodet commented on PR #24855:
URL: https://github.com/apache/camel/pull/24855#issuecomment-5005106103
_Claude Code on behalf of gnodet_
@apupier Thank you for the feedback! All your review comments have been
addressed:
1. **FileInvalidStartingPathTest** — now verifies the endpoint content:
checks `assertInstanceOf(FileEndpoint.class)` and
`assertNotNull(fileEndpoint.getFileName())` to confirm the endpoint has a
fileName expression configured.
2. **FileProduceTempPrefixTest** — now asserts on the created file: lists
files in the test directory, verifies at least one was created, reads its
content with `Files.readAllBytes()`, and asserts `assertEquals("Bye World",
content)`. This handles the UUID-based filename as you noted.
3. **CustomSchemaFactoryFeatureTest** — now verifies the endpoint contains
the custom schema factory: checks `assertInstanceOf(ValidatorEndpoint.class)`,
`assertNotNull(ve.getSchemaFactory())`, and
`assertFalse(ve.getSchemaFactory().getFeature(FEATURE_SECURE_PROCESSING))` to
confirm the custom factory (with secure processing disabled) is correctly wired.
Also fixed a compilation error (`IOException` not declared) that the CI
caught. Could you please re-review when you get a chance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
