davsclaus commented on PR #24977:
URL: https://github.com/apache/camel/pull/24977#issuecomment-5033088525
Thanks for the review @gnodet!
**1. `Thread.sleep(3000)` in `ResilienceAsyncTimeoutWriteBackRaceTest`**
The `Thread.sleep` here is intentional — it simulates a slow processor (the
"work" under test), not a test wait condition. The `finally {
workerDone.countDown() }` block relies on the synchronous execution context to
verify the worker thread completed after the timeout fired. Replacing with
`delay()` EIP would lose the ability to count down the latch in a `finally`
block. The existing sync counterpart (`ResilienceTimeoutWriteBackRaceTest`)
uses the same pattern.
**2. Option removals in the diff**
The removed options (`bulkheadFairCallHandlingEnabled`,
`maxWaitDurationInHalfOpenState`, `slidingWindowSynchronizationStrategy`) are
not from this PR — they are regeneration artifacts from the prior CAMEL-24137
(Circuit Breaker EIP modernization phase 1) already merged on `main`. This PR
only adds the new `asynchronous` option (default `false`, no behavioral
change). Those removals are already documented in the upgrade guide under the
CAMEL-24137 changes.
_Claude Code on behalf of davsclaus_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
