davsclaus commented on code in PR #25071: URL: https://github.com/apache/camel/pull/25071#discussion_r3643189631
########## components/camel-telemetry/src/test/java/org/apache/camel/telemetry/decorators/GoogleFunctionsSpanDecoratorTest.java: ########## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.camel.telemetry.decorators; + +import org.apache.camel.Endpoint; +import org.apache.camel.Exchange; +import org.apache.camel.Message; +import org.apache.camel.telemetry.mock.MockSpanAdapter; +import org.junit.jupiter.api.Test; +import org.mockito.Mockito; + +import static org.junit.jupiter.api.Assertions.assertEquals; + +public class GoogleFunctionsSpanDecoratorTest { Review Comment: Minor: per project conventions, new test classes should be package-private (drop `public`). Same applies to the `testPre()` method below. This is consistent with batch 1 so non-blocking, but worth aligning for new code. ```suggestion class GoogleFunctionsSpanDecoratorTest { ``` ########## components/camel-telemetry/src/test/java/org/apache/camel/telemetry/decorators/GoogleVertexAISpanDecoratorTest.java: ########## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.camel.telemetry.decorators; + +import org.apache.camel.Endpoint; +import org.apache.camel.Exchange; +import org.apache.camel.Message; +import org.apache.camel.telemetry.mock.MockSpanAdapter; +import org.junit.jupiter.api.Test; +import org.mockito.Mockito; + +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertNull; Review Comment: Minor: per project conventions, new test code should use AssertJ assertions. For example: ```java import static org.assertj.core.api.Assertions.assertThat; assertThat(span.tags().get(GoogleVertexAISpanDecorator.VERTEXAI_OPERATION)).isEqualTo(operation); assertThat(span.tags()).doesNotContainKey("prompt"); ``` Applies to all 6 test files. Non-blocking since batch 1 uses the same pattern. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
