oscerd commented on code in PR #25071: URL: https://github.com/apache/camel/pull/25071#discussion_r3657354748
########## components/camel-telemetry/src/test/java/org/apache/camel/telemetry/decorators/GoogleFunctionsSpanDecoratorTest.java: ########## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.camel.telemetry.decorators; + +import org.apache.camel.Endpoint; +import org.apache.camel.Exchange; +import org.apache.camel.Message; +import org.apache.camel.telemetry.mock.MockSpanAdapter; +import org.junit.jupiter.api.Test; +import org.mockito.Mockito; + +import static org.junit.jupiter.api.Assertions.assertEquals; + +public class GoogleFunctionsSpanDecoratorTest { Review Comment: Done in 0b1ce67 — all six new decorator test classes and their testPre() methods are now package-private.\n\n_Claude Code on behalf of Andrea Cosentino (@oscerd)._ ########## components/camel-telemetry/src/test/java/org/apache/camel/telemetry/decorators/GoogleVertexAISpanDecoratorTest.java: ########## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.camel.telemetry.decorators; + +import org.apache.camel.Endpoint; +import org.apache.camel.Exchange; +import org.apache.camel.Message; +import org.apache.camel.telemetry.mock.MockSpanAdapter; +import org.junit.jupiter.api.Test; +import org.mockito.Mockito; + +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertNull; Review Comment: Done in 0b1ce67 — converted all six to AssertJ using @apupier's form: assertThat(span.tags()).containsEntry(KEY, value) for the tag checks and .doesNotContainKey("prompt")/.doesNotContainKey("chatMessages") for the redaction assertions. Added a test-scoped assertj-core dependency to camel-telemetry. Thanks both.\n\n_Claude Code on behalf of Andrea Cosentino (@oscerd)._ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
