oscerd commented on PR #25218:
URL: https://github.com/apache/camel/pull/25218#issuecomment-5129306569
Thanks for the re-review, @gnodet. I believe the iterator finding is a
misread of the diff — both iterators **do** apply `FileUtil.stripPath()` to
`CamelFileName`. The lines cited (ZipIterator:148, TarIterator:135) are the
*dedicated full-name headers*, not `CamelFileName`:
**ZipIterator.java**
- L148 `answer.setHeader("zipFileName", zipFileName);` ← full name preserved
on the dedicated header
- L151 `answer.setHeader(Exchange.FILE_NAME,
FileUtil.stripPath(zipFileName));` ← **CamelFileName stripped**
**TarIterator.java**
- L135 `answer.setHeader(TARFILE_ENTRY_NAME_HEADER, current.getName());` ←
full name on `CamelTarFileEntryName`
- L139 `answer.setHeader(Exchange.FILE_NAME,
FileUtil.stripPath(current.getName()));` ← **CamelFileName stripped**
So the splitter paths (`ZipSplitter`/`TarSplitter`, which iterate via these
classes) are covered, and the upgrade-guide wording ("both the data format and
the iterator/splitter modes") is accurate.
`ZipFileNameStripPathTest`/`TarFileNameStripPathTest` exercise the iterator
path.
Both iterator files are in the diff (`git diff origin/main...HEAD --
...ZipIterator.java ...TarIterator.java` shows the `FileUtil.stripPath`
change). Re-requesting review — happy to add an explicit `ZipSplitter`-based
test if you'd like belt-and-suspenders coverage.
_Claude Code on behalf of Andrea Cosentino (@oscerd)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
