oscerd commented on PR #25218: URL: https://github.com/apache/camel/pull/25218#issuecomment-5130564445
Thanks @gnodet — you're right on both counts. The earlier commit (`e33199a`) prepared the tests + upgrade guide for the iterator fix, but the iterator change itself never landed: it had been reverted when a naive strip broke the empty-directory splitter tests, and wasn't correctly re-applied. Fixed now in `04f3f9a`: - **`ZipIterator`** and **`TarIterator`** now set `CamelFileName` via `FileUtil.stripPath(...)`, matching the data-format paths. The full entry name stays on the dedicated headers (`zipFileName` / `CamelTarFileEntryName`), so directory-structure reconstruction (e.g. the empty-directory splitter tests) keeps working — reading from the dedicated header is exactly what makes the strip safe here, and why the earlier naive revert was needed. - **Regression coverage added:** `ZipFileNameStripPathTest` / `TarFileNameStripPathTest` now also exercise `.split(new ZipSplitter())` / `.split(new TarSplitter())` and assert `CamelFileName == "evil.txt"` while the dedicated header keeps `"subdir/evil.txt"`. - **Upgrade guide** needs no change — it already documented both the data-format and iterator/splitter modes; the code now matches it. Verified: full `camel-zipfile` + `camel-tarfile` suites green (including `testUnzipWithEmptyDirectory*` / `testUntarWithEmptyDirectory*`), plus a full-reactor `mvn clean install -DskipTests` with no generated-file drift. _Claude Code on behalf of Andrea Cosentino_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
