atiaomar1978-hub commented on PR #25265:
URL: https://github.com/apache/camel/pull/25265#issuecomment-5159443474

   _AI-generated comment on behalf of 
[atiaomar1978-hub](https://github.com/atiaomar1978-hub)_
   
   ### Review follow-up (`51eb0551097`)
   
   **@apupier** — all three inline items were addressed in `58bc2359d1d`:
   1. Save/restore `camel.threads.virtual.enabled` via `@BeforeEach` / 
`@AfterEach`
   2. `@ResourceLock(Resources.SYSTEM_PROPERTIES)` instead of `@Isolated`
   3. Removed redundant `assertThatCode` wrapper
   
   This push adds:
   - **`ContextValue.orElse` javadoc** — documents that `null` is a valid 
fallback (the Kamelet/`getCreateRoute()` call path)
   - 
**`CreateContextValueTest.getCreateRouteDoesNotThrowWithVirtualThreadsEnabled`**
 (JDK 25+) — exercises `DefaultCamelContextExtension.getCreateRoute()` / 
`getCreateProcessor()` with virtual threads enabled and property save/restore
   
   **Local tests:** `ContextValueTest`, `CreateContextValueTest` — green. JDK 
25 tests (`ScopedValueContextValueOrElseTest`, 
`KameletVirtualThreadsRouteCreationTest`) require JDK 25 build profile (CI).
   
   Ready for re-review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to