christosgkoros commented on PR #25390:
URL: https://github.com/apache/camel/pull/25390#issuecomment-5214834950
Fixed in `d4c5f8e`. You were right — those four files were derived from the
two changes I made in response to your review, and I had regenerated only some
of the downstream artefacts.
| File | Why it was stale |
|---|---|
| catalog copy of `rest-postman-component.adoc` | not regenerated after the
AsciiDoc passthrough fix |
| `RestPostmanComponentBuilderFactory` | not regenerated after the
`consumerComponentName` reword |
| `RestPostmanEndpointBuilderFactory` | same |
| `SensitiveUtils` | see below |
`SensitiveUtils` was a different problem: my commit carried an unintended
re-indentation of the `// SENSITIVE-PATTERN: END` marker that the generator
does not produce. It is reverted, so that file now differs from `main` only by
the two `postmanapikey` entries. I confirmed `formatter:format` and
`impsort:sort` leave it alone, so it should not drift again.
To make sure this is actually fixed rather than just locally plausible, I
reproduced what CI does end to end:
```
mvn install -Dquickly # BUILD SUCCESS
mvn install -DskipTests -pl catalog/camel-catalog,core/camel-util,\
dsl/camel-componentdsl,dsl/camel-endpointdsl,dsl/camel-kamelet-main,docs
# BUILD SUCCESS
git status --short # empty
```
Also confirmed on the previous run that this was the only real failure: on
`6607c56` the JDK 25 `maven build` step passed and only `Fail if there are
uncommitted changes` failed; JDK 17 was cancelled by fail-fast rather than
failing on its own. The `Validate documentation` job went green, so the
asciidoctor fix worked.
While I was at it I checked that `RestOpenApiConsumerFactory` no longer
appears in any user-facing text — docs, catalog json, or the generated DSL
builders. It remains only in the Java code, where it is the actual API being
called.
_Claude Code on behalf of @christosgkoros_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
