atiaomar1978-hub commented on PR #25390:
URL: https://github.com/apache/camel/pull/25390#issuecomment-5224923498
## Updated review (post `70a80ea`)
Re-reviewed after the latest push. **Approve** — prior request-changes items
are resolved.
### Fixed since last review
| Item | Status |
|------|--------|
| Upgrade guide drift vs `main` | **Fixed** —
`camel-4x-upgrade-guide-4_22.adoc` has zero diff against `apache/camel` `main` |
| JIRA, exception wrapping, docs passthrough, derived file regen | **Fixed**
(per @davsclaus feedback) |
| `PostmanVariableResolver` placeholder-function injection (`{{env:...}}`,
`{{sys:...}}`, `{{bean:...}}`) | **Fixed** in `70a80ea` —
`isSafeToResolveAsProperty()` blocks `prefix:value` names; covered by tests |
| Per-fetch `HttpClient` thread leak in `PostmanCloudClient` | **Fixed** —
client built once in constructor |
| Sub-exchange UoW leak in `RestPostmanRunnerProducer` | **Fixed** —
`releaseUnitOfWork(sub)` in runner loop |
### Remaining (non-blocking)
1. **405 / empty `Allow` on matched paths** — author-documented gap when
vert.x router handles wrong-method before the processor runs. Acceptable for
v1; optional follow-up with `platform-http`.
2. **Branch name** `feat/camel-rest-postman-component` vs
`feature/CAMEL-24367-...` — convention only.
### Highlights
- Strong security design: separated Postman API key vs collection auth,
redirect rejection, HTTPS enforcement, bounded reads, auth/secret redaction, no
script execution
- No new third-party dependencies
- 167 component tests + 8 `platform-http` consumer tests
- Clear component documentation
Ready for committer merge review.
_AI-generated review on behalf of atiaomar1978-hub_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
