atiaomar1978-hub commented on PR #25474:
URL: https://github.com/apache/camel/pull/25474#issuecomment-5273248190
## Bugbot / Grok re-review — fixes applied
_AI-generated comment on behalf of atiaomar1978-hub (Cursor Agent)_
Re-ran bugbot review on the Phase 2 changeset and addressed the following
findings in commit a94b367:
| Severity | Finding | Fix |
|----------|---------|-----|
| **High** | EventBridge `putEvents` converted Map/List `data` via
`Object.toString()` producing invalid JSON (`{key=value}`) | Added
`jsonDataValue()` using Gson (already on classpath via Alibaba SDK) to
serialize structured data as proper JSON |
| **High** | KMS `plaintext` / `ciphertextBlob` marked `secret=true` in
source but missing from generated `SECRET_PROPERTY_NAMES` and catalog (`secret:
false`) | Regenerated component metadata + catalog so both params are in
`SECRET_PROPERTY_NAMES` with `secret: true` / `security: secret` |
| **Medium** | No test coverage for Map-bodied EventBridge events | Added
`testPutEventsWithMapBody` verifying JSON payload in CloudEvent data |
### Previously fixed (commit eacafe1)
- KMS encrypt Base64-encodes plaintext before API call
- FC invoke preserves binary response as `byte[]`
- KMS secret annotations on endpoint params
### Tests
All alibaba module unit tests pass locally:
```bash
cd components/camel-alibaba && ../../mvnw test
```
Please re-run CI when convenient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
